refactoring: DbUpdateSlotIndexToNull

stanislav-shchetinin · Oct 14, 2024 · 092d8cb · 092d8cb
1 parent 19910f0
commit 092d8cb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/ydb/core/mind/node_broker.cpp b/ydb/core/mind/node_broker.cpp
@@ -844,6 +844,15 @@ void TNodeBroker::DbUpdateNodeLocation(const TNodeInfo &node,
     db.Table<T>().Key(node.NodeId).Update<T::Location>(node.Location.GetSerializedLocation());
 }
 
+void TNodeBroker::DbUpdateSlotIndexToNull(const TNodeInfo &node,
+                                       TTransactionContext &txc) 
+{
+    NIceDb::TNiceDb db(txc.DB);
+    using T = Schema::Nodes;
+    db.Table<T>().Key(node.NodeId)
+    .UpdateToNull<T::SlotIndex>();
+}
+
 void TNodeBroker::Handle(TEvConsole::TEvConfigNotificationRequest::TPtr &ev,
                          const TActorContext &ctx)
 {   

diff --git a/ydb/core/mind/node_broker__decommission_node.cpp b/ydb/core/mind/node_broker__decommission_node.cpp
@@ -54,11 +54,7 @@ class TNodeBroker::TTxDecommissionNode : public TTransactionBase<TNodeBroker> {
 
             if (Self->EnableDecomissionNode) {
                 Self->SlotIndexesPools[node.ServicedSubDomain].Release(node.SlotIndex.value());
-
-                NIceDb::TNiceDb db(txc.DB);
-                using T = Schema::Nodes;
-                db.Table<T>().Key(node.NodeId)
-                .UpdateToNull<T::SlotIndex>();
+                Self->DbUpdateSlotIndexToNull(node, txc);
             }
             return true;
         }

diff --git a/ydb/core/mind/node_broker_impl.h b/ydb/core/mind/node_broker_impl.h
@@ -291,6 +291,8 @@ class TNodeBroker : public TActor<TNodeBroker>
                            TTransactionContext &txc);
     void DbUpdateNodeLocation(const TNodeInfo &node,
                               TTransactionContext &txc);
+    void DbUpdateSlotIndexToNull(const TNodeInfo &node,
+                                       TTransactionContext &txc);
 
     void Handle(TEvConsole::TEvConfigNotificationRequest::TPtr &ev,
                 const TActorContext &ctx);