minor change in ESS estimation in mcse_sd based on more simulations #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mcse_sd was estimating ESS from abs(x-E[x]). In my old simulations, this had worked better than (x-E[x])^2. It's likely that the change in how the rest of MCSE for sd is estimated (PR #233) did affect that now the more logical (x-E[x])^2 works better, as demonstrated by simulations run by @sethaxen.
Here are the plots for the new simulation results
![image](https://user-images.githubusercontent.com/6705400/210242930-840f9445-f1fb-4543-87f2-b92297bbbb66.png)
![image](https://user-images.githubusercontent.com/6705400/210242974-6f776e1a-02b4-4a7a-ae36-a359ae98f491.png)
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: