Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeesEscrow contract for Mainnet #109

Merged
merged 14 commits into from
Sep 9, 2022
Merged

FeesEscrow contract for Mainnet #109

merged 14 commits into from
Sep 9, 2022

Conversation

krbrton
Copy link
Contributor

@krbrton krbrton commented Aug 9, 2022

No description provided.

@krbrton krbrton requested a review from tsudmi August 9, 2022 20:07
contracts/interfaces/IPool.sol Outdated Show resolved Hide resolved
contracts/interfaces/IPoolMEV.sol Outdated Show resolved Hide resolved
contracts/interfaces/IPoolMEV.sol Outdated Show resolved Hide resolved
contracts/interfaces/IPoolMEV.sol Outdated Show resolved Hide resolved
contracts/interfaces/IPoolMEV.sol Outdated Show resolved Hide resolved
contracts/interfaces/IPoolMEV.sol Outdated Show resolved Hide resolved
contracts/interfaces/IRewardEthToken.sol Outdated Show resolved Hide resolved
contracts/pool/PoolMEV.sol Outdated Show resolved Hide resolved
contracts/tokens/RewardEthToken.sol Outdated Show resolved Hide resolved
contracts/tokens/RewardEthToken.sol Outdated Show resolved Hide resolved
contracts/interfaces/IFeesEscrow.sol Outdated Show resolved Hide resolved
contracts/pool/FeesEscrow.sol Outdated Show resolved Hide resolved
contracts/pool/Pool.sol Outdated Show resolved Hide resolved
contracts/pool/FeesEscrow.sol Outdated Show resolved Hide resolved
contracts/pool/FeesEscrow.sol Outdated Show resolved Hide resolved
contracts/pool/FeesEscrow.sol Outdated Show resolved Hide resolved
@krbrton krbrton force-pushed the pool-mev branch 2 times, most recently from 40804af to 639dac5 Compare August 10, 2022 19:41
contracts/interfaces/IFeesEscrow.sol Outdated Show resolved Hide resolved
contracts/pool/FeesEscrow.sol Outdated Show resolved Hide resolved
test/pool/FeesEscrow.test.js Outdated Show resolved Hide resolved
test/pool/FeesEscrow.test.js Show resolved Hide resolved
test/pool/FeesEscrow.test.js Outdated Show resolved Hide resolved
contracts/tokens/RewardEthToken.sol Outdated Show resolved Hide resolved
contracts/tokens/RewardEthToken.sol Outdated Show resolved Hide resolved
contracts/pool/FeesEscrow.sol Outdated Show resolved Hide resolved
contracts/pool/FeesEscrow.sol Outdated Show resolved Hide resolved
contracts/pool/FeesEscrow.sol Show resolved Hide resolved
deployments/index.js Outdated Show resolved Hide resolved
hardhat.config.js Outdated Show resolved Hide resolved
@krbrton krbrton force-pushed the pool-mev branch 3 times, most recently from 179a9e8 to d3f3cbc Compare August 12, 2022 11:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #109 (763a6ec) into master (9760ef7) will increase coverage by 29.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #109       +/-   ##
===========================================
+ Coverage    8.79%   37.85%   +29.06%     
===========================================
  Files          15       16        +1     
  Lines         557      560        +3     
  Branches      117      115        -2     
===========================================
+ Hits           49      212      +163     
+ Misses        508      348      -160     
Impacted Files Coverage Δ
contracts/pool/FeesEscrow.sol 100.00% <100.00%> (ø)
contracts/pool/Pool.sol 98.50% <100.00%> (+98.50%) ⬆️
contracts/tokens/RewardEthToken.sol 91.20% <100.00%> (+91.20%) ⬆️
contracts/presets/OwnablePausableUpgradeable.sol 100.00% <0.00%> (+10.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@krbrton krbrton force-pushed the pool-mev branch 4 times, most recently from d9ba255 to becf094 Compare August 24, 2022 18:34
@tsudmi tsudmi changed the title PoolMEV contract for reward accumulation Fees Escrow contract for Mainnet Aug 25, 2022
@tsudmi tsudmi changed the title Fees Escrow contract for Mainnet FeesEscrow contract for Mainnet Aug 25, 2022
@tsudmi tsudmi merged commit 29a802e into master Sep 9, 2022
@tsudmi tsudmi deleted the pool-mev branch September 9, 2022 15:41
cliddlebd pushed a commit to cliddlebd/contracts that referenced this pull request Sep 21, 2023
* FeesEscrow contract

* Fixes for tests and contracts

* Fixes

* Fix .openzeppelin

* ci linter fixes

* fixes for revertedWith

* Fixes

* network readme upd

* Deploy fees escrow to goerli

* Remove upgrade for Pool, update docstrings

* Fix tests

* Update deployments

* Deploy Fees Escrow contract

* Add Pessimistic audit report

Co-authored-by: Dmitry Pavlov <typticat@gmail.com>
Co-authored-by: Dmitri Tsumak <tsumak.dmitri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants