Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpc probe to deployment #311

Merged
merged 1 commit into from
May 9, 2024
Merged

Add grpc probe to deployment #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions application/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,9 @@ spec:
{{- else if .Values.deployment.startupProbe.tcpSocket }}
tcpSocket:
{{- toYaml .Values.deployment.startupProbe.tcpSocket | nindent 12 }}
{{- else if .Values.deployment.startupProbe.grpc }}
grpc:
{{- toYaml .Values.deployment.startupProbe.grpc | nindent 12 }}
{{- end }}
{{- end }}
{{- if .Values.deployment.livenessProbe.enabled }}
Expand All @@ -217,6 +220,9 @@ spec:
{{- else if .Values.deployment.livenessProbe.tcpSocket }}
tcpSocket:
{{- toYaml .Values.deployment.livenessProbe.tcpSocket | nindent 12 }}
{{- else if .Values.deployment.livenessProbe.grpc }}
grpc:
{{- toYaml .Values.deployment.livenessProbe.grpc | nindent 12 }}
{{- end }}
{{- end }}
{{- if .Values.deployment.readinessProbe.enabled }}
Expand All @@ -235,6 +241,9 @@ spec:
{{- else if .Values.deployment.readinessProbe.tcpSocket }}
tcpSocket:
{{- toYaml .Values.deployment.readinessProbe.tcpSocket | nindent 12 }}
{{- else if .Values.deployment.readinessProbe.grpc }}
grpc:
{{- toYaml .Values.deployment.readinessProbe.grpc | nindent 12 }}
{{- end }}
{{- end }}
{{- if or (.Values.deployment.volumeMounts) (and (eq .Values.persistence.enabled true) (eq .Values.persistence.mountPVC true) )}}
Expand Down
21 changes: 21 additions & 0 deletions application/tests/deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,24 @@ tests:
- equal:
path: spec.template.spec.serviceAccountName
value: example-app

- it: uses grpc probing when set
set:
applicationName: example-app
deployment.startupProbe.enabled: true
deployment.startupProbe.grpc.port: 5000
deployment.readinessProbe.enabled: true
deployment.readinessProbe.grpc.port: 5000
deployment.livenessProbe.enabled: true
deployment.livenessProbe.grpc.port: 5000
asserts:
- equal:
path: spec.template.spec.containers[0].startupProbe.grpc.port
value: 5000
- equal:
path: spec.template.spec.containers[0].readinessProbe.grpc.port
value: 5000
- equal:
path: spec.template.spec.containers[0].livenessProbe.grpc.port
value: 5000

3 changes: 3 additions & 0 deletions application/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ deployment:
httpGet: {}
exec: {}
tcpSocket: {}
grpc: {}

readinessProbe:
enabled: false
Expand All @@ -221,6 +222,7 @@ deployment:
httpGet: {}
exec: {}
tcpSocket: {}
grpc: {}

livenessProbe:
enabled: false
Expand All @@ -233,6 +235,7 @@ deployment:
httpGet: {}
exec: {}
tcpSocket: {}
grpc: {}

# Resources to be defined for pod
resources:
Expand Down
Loading