Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatusCake: Handling rate limits when working with Monitors #617

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

evilgn0me
Copy link
Contributor

@evilgn0me evilgn0me commented Nov 29, 2024

Current behaviour is that any request that receives 429 statuscode counts as a failure, leading to new monitors being created. Making controller to create duplicate monitors until you get maximum amount of monitors.
This PR addresses issues with exceeding StatusCake API rate limits by:

  1. Adding a rate limiter to cap requests at 5 per second.
  2. Implementing retries for 429 Too Many Requests responses, respecting the Retry-After header.

@karl-johan-grahn karl-johan-grahn merged commit f2d117a into stakater:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants