Statuscake: read basicauth password straight from secret #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the broken v0.9 of controller-gen because it causes a segfault when running `make install`
I don't like formatting :(
This is so that my upstream PR just focuses on the important bits rather than mixing changes
SheryarButt
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of 3 in which I upstream some changes I made to the operator because it was missing functionality that we wanted.
Changes
This PR adds the ability to read basic auth data straight from a secret rather than from an env variable. This is nice because you do not need to restart the operator for it to load in new env variables, it can just load the secret while still running. I have kept the old option because I did not want to introduce any breaking changes. I have also updated the docs and CRDs and such. Let me know if I have missed anything.