Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uptime robot alert contacts to be updated on monitors #139

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

daveshepherd
Copy link
Contributor

Hi, another change, if it's OK.

It looks like uptime robot contacts are added to monitors when they are created, but if the configuration is changed later they will never get updated.

@stakater-user
Copy link
Contributor

@daveshepherd Image is available for testing. docker pull stakater/ingressmonitorcontroller:PR-139-1

@rasheedamir rasheedamir requested a review from waseem-h January 16, 2019 18:12
Copy link
Contributor

@waseem-h waseem-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @daveshepherd !

@waseem-h waseem-h merged commit 33a2f55 into stakater:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants