Skip to content

Commit

Permalink
Merge pull request #449 from stakater/stale-issues
Browse files Browse the repository at this point in the history
Add automation to remove stale issues, remove deprecated log arg
  • Loading branch information
LilShah authored Apr 12, 2023
2 parents f505abf + 2645377 commit 885814d
Show file tree
Hide file tree
Showing 8 changed files with 31 additions and 10 deletions.
22 changes: 22 additions & 0 deletions .github/workflows/issues.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Close inactive issues
on:
schedule:
- cron: "30 1 * * *"

jobs:
close-issues:
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
- uses: actions/stale@v5
with:
days-before-issue-stale: 60
days-before-issue-close: 30
stale-issue-label: "stale"
stale-issue-message: "This issue is stale because it has been open for 60 days with no activity."
close-issue-message: "This issue was closed because it has been inactive for 30 days since being marked as stale."
days-before-pr-stale: -1
days-before-pr-close: -1
repo-token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion api/v1alpha1/endpointmonitor_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ type StatusCakeConfig struct {
// +optional
NodeLocations string `json:"nodeLocations,omitempty"`

// Comma seperated list of HTTP codes to trigger error on
// Comma separated list of HTTP codes to trigger error on
// +optional
StatusCodes string `json:"statusCodes,omitempty"`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ spec:
description: Enable Real Browser
type: boolean
statusCodes:
description: Comma seperated list of HTTP codes to trigger error
description: Comma separated list of HTTP codes to trigger error
on
type: string
testTags:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ spec:
description: Enable Real Browser
type: boolean
statusCodes:
description: Comma seperated list of HTTP codes to trigger error
description: Comma separated list of HTTP codes to trigger error
on
type: string
testTags:
Expand Down
1 change: 0 additions & 1 deletion charts/ingressmonitorcontroller/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ spec:
- args:
- --secure-listen-address=0.0.0.0:8443
- --upstream=http://127.0.0.1:8080/
- --logtostderr=true
- --v=0
image: {{ printf "%s:%s" .image.repository .image.tag | default "gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0" | quote }}
imagePullPolicy: {{ .image.pullPolicy | quote }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ spec:
description: Enable Real Browser
type: boolean
statusCodes:
description: Comma seperated list of HTTP codes to trigger error
description: Comma separated list of HTTP codes to trigger error
on
type: string
testTags:
Expand Down
8 changes: 4 additions & 4 deletions docs/uptimerobot-configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ You will get a response similar to what is shown below
]
```

Copy values of `id` field of your alert contacts which you want to use for Ingress Monitor Controller and append `_0_0` to them and seperate them by `-`. You will now have a string similar to `12345_0_0-23564_0_0`. This is basically the value you will need to specify in Ingress Monitor Controller's ConfigMap as `alertContacts`.
Copy values of `id` field of your alert contacts which you want to use for Ingress Monitor Controller and append `_0_0` to them and separate them by `-`. You will now have a string similar to `12345_0_0-23564_0_0`. This is basically the value you will need to specify in Ingress Monitor Controller's ConfigMap as `alertContacts`.

## Configuration

Expand Down Expand Up @@ -82,7 +82,7 @@ You will get a response similar to what is shown below
}
```

Copy values of `id` field of your public status page which you want to use for Ingress Monitor Controller into the relevant EndpointMonitor CR.
Copy values of `id` field of your public status page which you want to use for Ingress Monitor Controller into the relevant EndpointMonitor CR.

### Fetching maintenance windows from UpTime Robot

Expand Down Expand Up @@ -121,7 +121,7 @@ You will get a response similar to what is shown below
Copy values of `id` field of the maintenance windows which you want to use for Ingress Monitor Controller and separate them by `-`. You will now have a string similar to `12345-23564`. This is basically the value you will need to specify in the maintenance-windows EndpointMonitor CR.


## Example:
## Example:

```yaml
apiVersion: endpointmonitor.stakater.com/v1alpha1
Expand All @@ -139,5 +139,5 @@ spec:
keywordExists: true
keywordValue: 404
statusPages: "status-page"

```
2 changes: 1 addition & 1 deletion pkg/monitors/pingdom/pingdom-monitor.go
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ func (service *PingdomMonitorService) addConfigToHttpCheck(httpCheck *pingdom.Ht
log.Info("Should contain detected. Setting Should Contain string: " + providerConfig.ShouldContain)
}

// Tags should be a single word or multiple comma-seperated words
// Tags should be a single word or multiple comma-separated words
if providerConfig != nil && len(providerConfig.Tags) > 0 {
if !strings.Contains(providerConfig.Tags, " ") {
httpCheck.Tags = providerConfig.Tags
Expand Down

0 comments on commit 885814d

Please sign in to comment.