Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docker image tag #18

Merged
merged 6 commits into from
Mar 10, 2022
Merged

Updating docker image tag #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
228ccb9
Updating tags
Muneebstakater Mar 10, 2022
8cd2917
Updating build-args
Muneebstakater Mar 10, 2022
6532fc8
Updating sonarqube-github-token
Muneebstakater Mar 10, 2022
a898c97
Adding sonar env in build args
Muneebstakater Mar 10, 2022
a348f62
Adding sonar env in build arg
Muneebstakater Mar 10, 2022
6a135c6
Updating push flow
Muneebstakater Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/pull_request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
pull_request:
branches:
- master

env:
SONARQUBE_VERSION: 8.9.7-community

jobs:
build:
Expand All @@ -20,7 +23,7 @@ jobs:
id: generate_tag
run: |
sha=${{ github.event.pull_request.head.sha }}
tag="SNAPSHOT-PR-${{ github.event.pull_request.number }}-${sha:0:8}"
tag="SNAPSHOT-PR-${{ env.SONARQUBE_VERSION }}-${{ github.event.pull_request.number }}-${sha:0:8}"
echo "##[set-output name=GIT_TAG;]$(echo ${tag})"
- name: Set up QEMU
uses: docker/setup-qemu-action@v1
Expand All @@ -44,7 +47,9 @@ jobs:
file: ${{ env.DOCKER_FILE_PATH }}
pull: true
push: true
build-args: BUILD_PARAMETERS=${{ env.BUILD_PARAMETERS }}
build-args: |
SONARQUBE_VERSION=${{ env.SONARQUBE_VERSION }}
BUILD_PARAMETERS=${{ env.BUILD_PARAMETERS }}
cache-to: type=inline
tags: |
${{ env.IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.GIT_TAG }}
Expand All @@ -55,7 +60,7 @@ jobs:
- name: Comment on PR
uses: mshick/add-pr-comment@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }}
with:
message: '@${{ github.actor }} Image is available for testing. `docker pull ${{ env.IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.GIT_TAG }}`'
allow-repeats: false
Expand All @@ -64,7 +69,7 @@ jobs:
if: failure()
uses: mshick/add-pr-comment@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.STAKATER_GITHUB_TOKEN }}
with:
message: '@${{ github.actor }} Yikes! You better fix it before anyone else finds out! [Build](https://github.com/${{ github.repository }}/commit/${{ github.event.pull_request.head.sha }}/checks) has Failed!'
allow-repeats: false
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
branches:
- master

env:
SONARQUBE_VERSION: 8.9.7-community

jobs:
build:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -49,7 +52,9 @@ jobs:
file: ${{ env.DOCKER_FILE_PATH }}
pull: true
push: true
build-args: BUILD_PARAMETERS=${{ env.BUILD_PARAMETERS }}
build-args: |
SONARQUBE_VERSION=${{ env.SONARQUBE_VERSION }}
BUILD_PARAMETERS=${{ env.BUILD_PARAMETERS }}
cache-to: type=inline
tags: |
${{ env.IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.new_tag }}
Expand Down
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM docker.io/sonarqube:8.9.7-community
ARG SONARQUBE_VERSION
FROM docker.io/sonarqube:${SONARQUBE_VERSION}

ENV CUSTOM_PLUGINS_DIR=/opt/sonarqube/extensions/plugins

Expand Down