Fix issue with expanded full screen layout for instructions #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthetechie
commented
Nov 5, 2024
Comment on lines
+131
to
+140
| modifier = | ||
| Modifier.offset { | ||
| IntOffset( | ||
| 0, | ||
| if (isExpanded) { | ||
| (-4 * density).toInt() | ||
| } else { | ||
| (-8 * density).toInt() | ||
| }) | ||
| } |
There was a problem hiding this comment.
Unfortunately the new layout structure required some changes here. Android Studio gave a lint warning that I should use this closure version of offset since it depends on state. TIL.
Archdoog
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure how this got past my testing, but there was something wrong with the layout in the last release, either as a result of complex interaction or perhaps because of how I did the lazy column the first time around. I still don't fully understand why, but even debugging the layout inspector live, the previous iteration would "push" the pill offscreen at which point it was dropped from the composable completely if the list of instructions were long!
Colllapsed:
Expanded (large):
Detail showing the layout inspector to show how the pill is carefully aligned: