Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voice guidance for web #190

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Add voice guidance for web #190

merged 3 commits into from
Aug 24, 2024

Conversation

CatMe0w
Copy link
Contributor

@CatMe0w CatMe0w commented Aug 24, 2024

No description provided.

@ianthetechie ianthetechie self-requested a review August 24, 2024 09:14
Copy link
Contributor

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Really nice to see this in before the end of GSoC 😍

And thanks for the added comments as well. Those make reading much smoother.

@@ -159,11 +166,14 @@ export class FerrostarCore extends LitElement {

// TODO: type
async startNavigation(route: any, config: any) {
// Remove the search box when navigation starts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch!

@ianthetechie ianthetechie merged commit 4cf92d7 into stadiamaps:main Aug 24, 2024
14 checks passed
@CatMe0w CatMe0w deleted the patch-tts branch August 25, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants