Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up warnings #42

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Clean up warnings #42

merged 2 commits into from
Oct 12, 2022

Conversation

gadomski
Copy link
Contributor

@gadomski gadomski commented Oct 12, 2022 •
edited
Loading

Related Issue(s):

Description:
Simple method changes to silence some warnings.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.
  • Examples are added to examples/

@gadomski
chore: clean up warnings
da62122 
Simple method changes to silence some warnings.
@gadomski gadomski requested a review from pjhartzell October 12, 2022 16:38
@gadomski gadomski changed the title clean up warnings Clean up warnings Oct 12, 2022
@pjhartzell pjhartzell merged commit 70d1779 into main Oct 12, 2022
@pjhartzell pjhartzell deleted the clean-up-warnings branch October 12, 2022 18:31
@pjhartzell pjhartzell mentioned this pull request Oct 12, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjhartzell pjhartzell pjhartzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @pjhartzell