Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address antimeridian failures on pre-split polygons #30

Merged
merged 4 commits into from
Apr 12, 2022
Merged

fix: address antimeridian failures on pre-split polygons #30

merged 4 commits into from
Apr 12, 2022

Conversation

pjhartzell
Copy link
Contributor

@pjhartzell pjhartzell commented Apr 12, 2022 •
edited
Loading

Closes #29

Related Issue(s):
#29

Description:
If the item geometry is a MultiPolygon along the antimeridian, merges the MultiPolygon so that it can either be "re-split" or normalized with the stactools antimeridian fix_item utility.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.
  • Examples are added to examples/

@pjhartzell pjhartzell requested a review from gadomski April 12, 2022 13:05
gadomski
gadomski reviewed Apr 12, 2022
View reviewed changes
src/stactools/landsat/utils.py Outdated Show resolved Hide resolved
tests/test_geometry.py Outdated Show resolved Hide resolved
@pjhartzell pjhartzell requested a review from gadomski April 12, 2022 15:02
@pjhartzell pjhartzell requested a review from gadomski April 12, 2022 15:36
@pjhartzell pjhartzell marked this pull request as ready for review April 12, 2022 15:59
@pjhartzell pjhartzell merged commit 56c1cdd into stactools-packages:main Apr 12, 2022
@pjhartzell pjhartzell deleted the fix/pjh/antimeridian-pre-split branch April 12, 2022 16:19
@TomAugspurger TomAugspurger mentioned this pull request Jun 15, 2022
Closed
@pjhartzell pjhartzell mentioned this pull request Oct 12, 2022
Merged
6 tasks
@TomAugspurger TomAugspurger mentioned this pull request Nov 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Antimeridian Failure
2 participants
@pjhartzell @gadomski