Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoX-4 unit testing #4698

Merged
merged 42 commits into from
May 3, 2024
Merged

PoX-4 unit testing #4698

merged 42 commits into from
May 3, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Apr 19, 2024

Add Clarity unit testing for the pox-4 contract.

obycode and others added 21 commits April 19, 2024 08:25
@obycode
test: starting to add pox-4 unit test
9a51e34
@hugocaillard @obycode
test: add pox-4 tests
7312379
@hugocaillard @obycode
--wip-- [skip ci]
adceea6
@hugocaillard @obycode
feat: refactor pox-4 unit tests
6f88f94
@obycode
test: add tests for delegate-stx
f167775
@obycode
chore: standardize describe/it phrases
97424ef
@obycode
test: add revoke-delegate-stx unit tests
55a8e07
@obycode
test: add unit tests for allow-contract-caller and `disallow-contra…
6eb1525 
…ct-caller`
@obycode
test: add disallow-contract-caller unit test
a7aaaf2
@hugocaillard @obycode
feat: solo-stacker tests
3a0c79c
@obycode
test: add helpers for delegate-stack-extend and
2ce93bc 
`delegate-stack-increase`
@hugocaillard @obycode
tests: add solo-stacker unlocked check
47e22f6
@obycode
test: add pox scenarios test
cce3995 
Initial test is validating the situation where a user switching pools
requires one cycle of down time.
@hugocaillard @obycode
feat: code coverage for pox-4 unit tests
3ad0a9c
@obycode
test: add more pox-4 unit tests
3838377
@obycode
test: add tests for verify-signer-key-sig
ec142f9
@obycode
test: add unit tests for stack-aggregation-commit-indexed
54cf079
@obycode
test: add unit tests for consume-signer-key-authorization
38f4cc2
@obycode
test: add unit tests for stack-aggregation-commit
261e70b
@obycode
test: add unit tests for delegate=stack-stx
4b73f36
@obycode
test: add unit tests for stack-stx
9d5718a
@obycode obycode changed the title Test/pox 4 unit PoX-4 unit testing Apr 19, 2024
@friedger
Copy link
Collaborator

Why not using the pox contract from stacks lib?

@obycode
Copy link
Contributor Author

obycode commented Apr 19, 2024

I was actually curious about that too. I think there was some reason related to coverage that @hugocaillard did that. I'll let him answer.

@friedger
Copy link
Collaborator

Coverage reports are broken. How do we ensure that the two pox files are always in sync? Maybe we can copy it over? Or make it a requirement?

@obycode obycode marked this pull request as ready for review April 25, 2024 21:00
@obycode
Copy link
Contributor Author

obycode commented Apr 25, 2024

Final coverage numbers:

Overall coverage rate:
  lines......: 96.1% (540 of 562 lines)
  functions......: 100.0% (60 of 60 functions)
  branches......: 80.7% (117 of 145 branches)

I believe that all of the remaining uncovered lines/branches are either unreachable or are from a weakness in Clarinet's coverage reporting.

@obycode obycode requested review from hugocaillard and setzeus April 25, 2024 21:13
@moodmosaic moodmosaic mentioned this pull request Apr 29, 2024
Merged
hugocaillard
hugocaillard previously approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@hugocaillard hugocaillard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@saralab saralab requested a review from kantai May 3, 2024 13:51
kantai
kantai previously approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obycode obycode enabled auto-merge May 3, 2024 15:13
@obycode
fix: revert changes in contrib/core-contract-tests/
9bce638 
The removal of package-lock.json causes `npm ci` to fail and it should
not be removed by this PR any way.
@obycode obycode dismissed stale reviews from kantai and hugocaillard via 9bce638 May 3, 2024 15:22
@obycode obycode requested review from kantai and hugocaillard May 3, 2024 15:22
hugocaillard
hugocaillard approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obycode obycode added this pull request to the merge queue May 3, 2024
Merged via the queue into develop with commit a9c14f9 May 3, 2024
1 check passed
@obycode obycode deleted the test/pox-4-unit branch May 3, 2024 16:38
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hugocaillard hugocaillard hugocaillard approved these changes

@kantai kantai kantai approved these changes

@setzeus setzeus Awaiting requested review from setzeus

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@obycode @friedger @hugocaillard @blockstack-devops @kantai