Refine the next cycle state refresh function #4693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nikos Baxevanis <nikos.baxevanis@gmail.com>
Co-authored-by: Nikos Baxevanis <nikos.baxevanis@gmail.com>
friedger
approved these changes
Apr 19, 2024
| // next empty reward slot) | ||
| else if ( | ||
| wallet.unlockHeight > 0 && | ||
| wallet.unlockHeight > burnBlockHeight + 1050 && wallet.isStackingSolo |
There was a problem hiding this comment.
nit: 1050 could be a constant.
There was a problem hiding this comment.
Yep. If it turns out we end up using it multiple times it can be extracted as a constant.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the state refreshing function for new cycles and targets
feat/pox-4-stateful-property-testing(#4550).