Add delegate-stack-extend command #4610
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/pox-4-stateful-property-testing #4610 +/- ##
========================================================================
- Coverage 83.31% 83.19% -0.13%
========================================================================
Files 470 470
Lines 332151 332151
Branches 317 317
========================================================================
- Hits 276743 276326 -417
- Misses 55400 55817 +417
Partials 8 8 see 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Merging into |
b26ad6a
into
feat/pox-4-stateful-property-testing
| (this.stacker.unlockHeight - FIRST_BURNCHAIN_BLOCK_HEIGHT) / | ||
| REWARD_CYCLE_LENGTH, | ||
| ); | ||
| const lastExtendCycle = firstExtendCycle + this.extendCount - 1; |
There was a problem hiding this comment.
Why do you need this value? You are substracting one and adding one afterwards.
There was a problem hiding this comment.
@friedger I am doing this to simulate how the lock period is calculated inside PoX-4 contract
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds the
delegate-stack-extendcommand to the stateful property testing environment. It is part of #4548 and targetsfeat/pox-4-stateful-property-testing(#4550).