feat: Mempool Analyzer #3020
feat: Mempool Analyzer #3020
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## develop #3020 +/- ##
===========================================
+ Coverage 82.22% 82.34% +0.11%
===========================================
Files 242 243 +1
Lines 195373 195564 +191
===========================================
+ Hits 160642 161031 +389
+ Misses 34731 34533 -198
Continue to review full report at Codecov.
|
| @@ -601,11 +602,12 @@ impl<'a> StacksMicroblockBuilder<'a> { | |||
| /// # Pre-Checks | |||
| /// - skip if the `anchor_mode` rules out micro-blocks | |||
| /// - skip if 'tx.txid()` is already in `considered` | |||
| /// - skip if adding the block would result in a block size bigger than `MAX_EPOCH_SIZE` | |||
| /// - skip if adding the block would result in a block size bigger than the block maximum | |||
There was a problem hiding this comment.
s/the block maximum/the maximum size of a block
| @@ -268,9 +286,52 @@ impl ClarityBlockConnection<'_> { | |||
| } | |||
| } | |||
|
|
|||
| // Maximum amount of data a leader can send during its epoch (2MB). | |||
| const MAX_EPOCH_SIZE: u32 = 2 * 1024 * 1024; | |||
There was a problem hiding this comment.
why are you redefining this constant here?
There was a problem hiding this comment.
I moved the definition here and made it private, so that it would be exposed only through the relevant BlockLimitsFn.
|
We could keep this in a side branch, but could still consider putting the hooks into |
|
Not checking this in now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Motivation
Towards #3002
New Code
This program can be used to "analyze the mempool". This can be used to compute statistics, especially:
More specifically, this tool can be used to mine an "unlimited block". That is, it will attempt to build a block from the transactions in the mempool, but will never run out of space in the block.
Each transaction in the mempool will be tried once.
Changed Code
To support this change, we introduce
BlockLimitsFunctions, which allows the user to specify custom block limits. Currently, there is no choice but to take the limits from theStacksEpoch. Now, users writing custom tools or tests will be able to override these values.Testing
The new memory analyzer tool is just tested by running it. It's not currently in production.
The changes to introduce
BlockLimitsFunctionsare tested by the existing tests.