-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] add txid to Emily withdrawals #1548
Conversation
Hey, @hozzjss, is it true that new withdrawals are posted to Emily from bridge ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly done! I'd just make the field mandatory to keep future tech debt at minimum
.generated-sources/emily/client/rust/private/src/models/create_withdrawal_request_body.rs
Outdated
Show resolved
Hide resolved
This reverts commit 89f6716.
I was thinking that we maybe want not Option here, thus I already have commit for not option |
Thanks for your comments @Jiloc, addressed them in two commits above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks @MCJOHN974 but no withdrawals are not posted to emily from the bridge (THANK GOD) |
Well, then from where they are pushed? I think we need update the pusher as well upd: it is pushed from stacks node via sidecar, no action needed |
We discussed this at the standup but I am going to add here the answer for future reference. The withdrawals events are sent by the sidecar to Emily via the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ✅
Description
Closes: #1529
Changes
Testing Information
This PR adds pretty stupid thing -- just 1 more field to input jsons, output json, and to db. We already have integration tests checking that withdrawal we put to Emily equals to withdrawal we extract from Emily. Thus just adding new field to structs in this tests should test everything we need
Checklist: