Add ability to customize WorkerOptions
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Tagged |
|
Hi, great PR! Just one suggestion, I think missing the readme changes. |
|
I knew I missed something 😄 Thanks @marickvantuil for merging this and for updating docs 👍 |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found ourselves in the need of specifying
maxRetriesandbackoffglobally on a queue basis, similar to how you can do it on Google Cloud Tasks. It makes it more convenient to have these parameters listed in a single place (most likely a config file) than having to implement them in every job and then trying to keep them in sync.I used a similar approach as it was done in #139 with handler url.
Initially I wanted to use the callback inside
getWorkerOptions()ofTaskHandler, but that method has not job or task context to get the queue from. AddingIncomingTaskargument to the method would introduce a breaking change in case someone has extended `TaskHandler.