Only Delete LoadBalancerMachine after a grace period #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timebertt
reviewed
Dec 4, 2023
controllers/yawol-controller/loadbalancerset/loadbalancermachine_status_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancermachine_status_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancermachine_status_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancermachine_status_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancermachine_status_controller.go
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancermachine_status_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancermachine_status_controller.go
Outdated
Show resolved
Hide resolved
controllers/yawol-controller/loadbalancerset/loadbalancerset_controller.go
Outdated
Show resolved
Hide resolved
timebertt
reviewed
Dec 4, 2023
timebertt
reviewed
Dec 4, 2023
timebertt
reviewed
Dec 4, 2023
timebertt
previously approved these changes
Dec 5, 2023
Kumm-Kai
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the apiservers/clusters are unavailable for a longer period of time there can be a race between yawollet and the
loadbalancermachine_status_controller, which wants to delete stale machines. A race which the yawollet is likely to lose, since its backoff is very high. (The controller is likely to be running again sooner, because it will be stuck in trying to get/renew its leader lease, which happens more frequently).This PR fixes this by introducing a grace period, before the LBM is actually deleted. So if the deletion conditions are met (
shouldMachineBeDeleted) we now set a condition, and only if that condition has passed the grace period (and the machine is still not ready), we actually delete it.At the same time, this caps the exponential error backoff of the yawollet to match the reconciliation period in the "happy path".