Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix bug where client TLS could not be disabled #529

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Fix bug where client TLS could not be disabled #529

wants to merge 5 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jul 25, 2022 •
edited by siegfriedweber
Loading

Description

  • Client TLS can now be disabled by setting spec.config.tls: null
spec:
  version: 3.8.0-stackable0.7.1
  config:
    tls: null
    clientAuthentication:
      authenticationClass: zk-client-tls
    quorumTlsSecretClass: tls

fixes #528

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team July 25, 2022 08:32
@siegfriedweber siegfriedweber requested review from siegfriedweber and removed request for a team July 27, 2022 07:57
siegfriedweber
siegfriedweber requested changes Jul 27, 2022
View reviewed changes
@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 28, 2022
@maltesander
Fix bug where client TLS could not be disabled (#529)
af1b680 
# Description

- Client TLS can now be disabled by setting `spec.config.tls: null`
```
spec:
  version: 3.8.0-stackable0.7.1
  config:
    tls: null
    clientAuthentication:
      authenticationClass: zk-client-tls
    quorumTlsSecretClass: tls
```

fixes #528



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix bug where client TLS could not be disabled [Merged by Bors] - Fix bug where client TLS could not be disabled Jul 28, 2022
@bors bors bot closed this Jul 28, 2022
@bors bors bot deleted the fix_tls_set_always_bug branch July 28, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Client TLS cannot be disabled
2 participants
@maltesander @siegfriedweber