[Merged by Bors] - Default ZookeeperClusterRef's namespace to the ns of the Znode #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2022
|
This functionality is also provided by #383, but that depends on stackabletech/operator-rs#307. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
## Description This ensures that references can now work without the manifest knowing which namespace it's being applied to.
|
Pull request successfully merged into main. Build succeeded: |
bors bot
added a commit
to stackabletech/operator-rs
that referenced
this pull request
Feb 4, 2022
307: Add `ClusterRef` as discussed at the last architecture meeting r=teozkr a=teozkr ## Description Inspired by `ZookeeperClusterRef` (including stackabletech/zookeeper-operator#382), but generalized and added some convenience methods. ## Review Checklist - [ ] Code contains useful comments - [ ] (Integration-)Test cases added (or not applicable) - [ ] Documentation added (or not applicable) - [ ] Changelog updated (or not applicable) Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
## Description This also incorporates the namespace-defaulting from #382 and, as such, supersedes it. Co-authored-by: Stacky McStackface <stackable-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures that references can now work without the manifest knowing which namespace it's being applied to.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information