Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add pause/stop feature to operator #348

Closed
wants to merge 6 commits into from

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Apr 3, 2023

Description

See #72.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@Techassi Techassi changed the title Bump operator-rs to 0.39.0 Add pause/stop feature to operator Apr 4, 2023
@Techassi Techassi marked this pull request as ready for review April 4, 2023 09:04
@Techassi Techassi requested a review from adwk67 April 4, 2023 09:04
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Techassi
Copy link
Member Author

Techassi commented Apr 4, 2023

bors merge

bors bot pushed a commit that referenced this pull request Apr 4, 2023
# Description

See [#72](stackabletech/issues#72).

## Definition of Done Checklist

- Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
- Please make sure all these things are done and tick the boxes
 
```[tasklist]
# Author
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
```

```[tasklist]
# Reviewer
- [x] Code contains useful comments
- [x] (Integration-)Test cases added
- [ ] Documentation added or updated
- [x] Changelog updated
- [x] Cargo.toml only contains references to git tags (not specific commits or branches)
```

```[tasklist]
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added
```

Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)


Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
@bors
Copy link
Contributor

bors bot commented Apr 4, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add pause/stop feature to operator [Merged by Bors] - Add pause/stop feature to operator Apr 4, 2023
@bors bors bot closed this Apr 4, 2023
@bors bors bot deleted the feat/pause-stop branch April 4, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants