[Merged by Bors] - Kerberos keytab backend #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
added a commit
to stackabletech/hdfs-operator
that referenced
this pull request
Apr 1, 2022
Proof of concept for testing stackabletech/secret-operator#99 There are still plenty of issues here that need to be solved before this is actually usable. For example, this will currently break when attempting to access the cluster from outside of K8s (since the Krb principals will mismatch).
6 tasks
|
Remaining questions:
|
nightkr
commented
Apr 7, 2022
# Conflicts: # Cargo.lock # Tiltfile # default.nix # provisioner.yaml # rust/operator-binary/Cargo.toml # rust/operator-binary/src/backend/dynamic.rs # rust/operator-binary/src/backend/mod.rs
|
stackabletech/hdfs-operator#154 has bitrotted a fair amount, there's https://github.com/stackabletech/hdfs-operator/tree/spike/security2 which is a lazier port but should at least be closer to working. |
sbernauer
reviewed
Mar 13, 2023
docker/Dockerfile
Outdated
| @@ -2,7 +2,7 @@ | |||
| # This file is automatically generated from the templates in stackabletech/operator-templating | |||
| # DON'T MANUALLY EDIT THIS FILE | |||
| # ============= | |||
| FROM docker.stackable.tech/stackable/ubi8-rust-builder AS builder | |||
| FROM docker.stackable.tech/natkr/krb5/ubi8-rust-builder AS builder | |||
There was a problem hiding this comment.
Marker. stackabletech/docker-images#338 is approved
There was a problem hiding this comment.
There was a problem hiding this comment.
e0e9f33 is about the krb image for the tests. This here is the ubi8-rust-builder, which is a different story
There was a problem hiding this comment.
ahh you're right. Silly me.
sbernauer
reviewed
Mar 14, 2023
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
|
Only two discussions left. Would be great if we could silence the hadolint check so that we can test the -pr99 helm chart... |
|
I don't believe hadolint blocks chart publishing. |
|
My mistake, you are right! |
|
bors |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
## Description This PR adds support for provisioning Kerberos principals and keytabs for pods, similar to the `autoTls` backend. Currently only MIT Kerberos is supported, Heimdal and Active Directory still require manual provisioning. There is a spike branch for the HDFS Operator (stackabletech/hdfs-operator#154) that uses this to provision a kerberized HDFS cluster. Co-authored-by: Teo Klestrup Röijezon <teo@nullable.se> Co-authored-by: Stacky McStackface <stackable-bot@users.noreply.github.com> Co-authored-by: Sönke Liebau <soenke.liebau@stackable.tech>
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for provisioning Kerberos principals and keytabs for pods, similar to the
autoTlsbackend.Currently only MIT Kerberos is supported, Heimdal and Active Directory still require manual provisioning.
There is a spike branch for the HDFS Operator (stackabletech/hdfs-operator#154) that uses this to provision a kerberized HDFS cluster.
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information