Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Allow users to disable CA auto-generation #77

Closed
wants to merge 5 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Mar 14, 2022

Description

Fixes #67

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr self-assigned this Mar 14, 2022
@nightkr nightkr requested review from lfrancke and a team March 14, 2022 10:21
@sbernauer
Copy link
Member

LGTM % comment

@nightkr nightkr requested a review from sbernauer March 14, 2022 11:49
…/secret-operator into feature/disable-ca-autogen
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Installed from helm and tested functionality.

@nightkr
Copy link
Member Author

nightkr commented Mar 16, 2022

bors r+

@nightkr
Copy link
Member Author

nightkr commented Mar 16, 2022

bors r-

@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

Canceled.

@nightkr
Copy link
Member Author

nightkr commented Mar 16, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors bot pushed a commit that referenced this pull request Mar 16, 2022

## Description

Fixes #67


Co-authored-by: Stacky McStackface <stackable-bot@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Mar 16, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Allow users to disable CA auto-generation [Merged by Bors] - Allow users to disable CA auto-generation Mar 16, 2022
@bors bors bot closed this Mar 16, 2022
@bors bors bot deleted the feature/disable-ca-autogen branch March 16, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAs should not be created automagically
4 participants