Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove h2 patch #495

Merged
merged 9 commits into from
Sep 6, 2024
Merged

chore: Remove h2 patch #495

merged 9 commits into from
Sep 6, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 5, 2024

Description

Part of stackabletech/issues#636

Tested using k8s 1.26 (kind create cluster --image kindest/node:v1.26.15)

--- PASS: kuttl (55.76s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/tls_openshift-false (29.43s)
        --- PASS: kuttl/harness/kerberos_krb5-1.21.1_openshift-false (52.96s)
        --- PASS: kuttl/harness/listener_openshift-false (26.32s)
PASS

On k8s 1.25.16 it fails with "Registration process failed with error, restarting registration container" err="RegisterPlugin error -- plugin registration failed with err: rpc error: code = Internal desc = stream terminated by RST_STREAM with error code: PROTOCOL_ERROR", so I'd call it fixed 👍

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer sbernauer self-assigned this Sep 6, 2024
@sbernauer sbernauer requested a review from nightkr September 6, 2024 06:12
@sbernauer sbernauer requested a review from a team September 6, 2024 06:41
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shall we set a reminder to delete the stackable/h2 repo (or at least archive it)?

@sbernauer
Copy link
Member Author

No opinion from my side :)

@sbernauer sbernauer added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit eb89492 Sep 6, 2024
31 checks passed
@sbernauer sbernauer deleted the chore/remove-h2-patch branch September 6, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants