Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Convert CSI listener socket back to non-blocking mode #47

Closed
wants to merge 2 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 8, 2022

Description

Fixes #45

This was a regression in #26, causing both slow shutdowns and general thread
starvation that could cause the operator to hang entirely in single-core environments.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr self-assigned this Feb 8, 2022
Fixes #45

This was a regression in #26, causing both slow shutdowns and general thread
starvation that could cause the operator to hang entirely in single-core environments.
@nightkr nightkr force-pushed the bugfix/nonblocking-csi-listener branch from abf0cdd to 20b4181 Compare February 8, 2022 09:36
@nightkr nightkr requested a review from a team February 8, 2022 09:47
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nightkr
Copy link
Member Author

nightkr commented Feb 8, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 8, 2022
## Description

Fixes #45

This was a regression in #26, causing both slow shutdowns and general thread
starvation that could cause the operator to hang entirely in single-core environments.

## Review Checklist
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added (or not applicable)
- [ ] Documentation added (or not applicable)
- [ ] Changelog updated (or not applicable)
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment `bors r+` (or `bors merge`) to merge. [Further information](https://bors.tech/documentation/getting-started/#reviewing-pull-requests)
@bors
Copy link
Contributor

bors bot commented Feb 8, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Convert CSI listener socket back to non-blocking mode [Merged by Bors] - Convert CSI listener socket back to non-blocking mode Feb 8, 2022
@bors bors bot closed this Feb 8, 2022
@bors bors bot deleted the bugfix/nonblocking-csi-listener branch February 8, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graceful operator shutdown is broken
2 participants