-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for encrypting PKCS#12 stores with a password #314
Conversation
I'm not sure if this is something that we want to document, since this is more of a desperate "feature of last resort". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Lets wait what the arch meeting brings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general okay after the comment for compat_tls_pkcs12_password
is fixed.
I would not emphasize it so much that the password is used for compatibility reasons. It is an option (and not a compatibility option) which is used for compatibility and not too useful on its own.
It only exists for compatibility, and provides no useful security improvement on its own. I absolutely want to avoid misleading people around this... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes #313.
We add a new volume parameter
secrets.stackable.tech/format.compatibility.tls-pkcs12.password
for controlling this. The password should not be considered private (PVC manifests are generally public!), this is purely for compatibility with certain broken apps.Definition of Done Checklist
Author
Reviewer
Acceptance