Listener scope #310

nightkr · 2023-08-29T16:33:36Z

Description

Fixes stackabletech/listener-operator#95

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

Author

Give feedback

Changes are OpenShift compatible
CRD changes approved
Helm chart can be installed and deployed operator works
Integration tests passed (for non trivial changes)
Options

Reviewer

Give feedback

Code contains useful comments
(Integration-)Test cases added
Documentation added or updated
Changelog updated
Cargo.toml only contains references to git tags (not specific commits or branches)
Options

Acceptance

Give feedback

Feature Tracker has been updated
Proper release label has been added
Options

rust/operator-binary/src/backend/k8s_search.rs

rust/operator-binary/src/backend/pod_info.rs

rust/operator-binary/src/backend/k8s_search.rs

rust/operator-binary/src/backend/pod_info.rs

rust/operator-binary/src/backend/mod.rs

nightkr · 2023-09-01T15:00:09Z

I'd call the secret-op parts R4R, but it still depends on stackabletech/listener-operator#100 before it can be used.

CHANGELOG.md

Cargo.toml

docs/modules/secret-operator/pages/scope.adoc

rust/operator-binary/src/backend/pod_info.rs

deploy/helm/secret-operator/templates/daemonset.yaml

Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>

…erator into feature/listener

Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>

…erator into feature/listener

siegfriedweber · 2023-11-06T09:46:21Z

Waiting for stackabletech/listener-operator#100 (comment) to be resolved. But otherwise LGTM.

siegfriedweber

LGTM

nightkr added 7 commits August 24, 2023 12:28

grpc listener integration

e9d4896

Read listeners from PodListeners instead of calling listop's CSI

4626bf0

Drop listop grpc

6289d71

Infer node scope for nodeport listeners

0b16680

Add listener scope to k8sSearch

c94eefc

Use resolved listener name for k8sSearch

f3aeb8e

Allow searching for multiple listener scopes

29507ab

nightkr mentioned this pull request Aug 29, 2023

Write PodListeners stackabletech/listener-operator#100

Merged

github-actions bot reviewed Aug 29, 2023

View reviewed changes

Use listener address tags rather than assuming DNS

c985cfc

github-actions bot reviewed Aug 29, 2023

View reviewed changes

Fix warnings

48d043b

github-actions bot reviewed Aug 30, 2023

View reviewed changes

rust/operator-binary/src/backend/mod.rs Outdated Show resolved Hide resolved

rust/operator-binary/src/backend/mod.rs Outdated Show resolved Hide resolved

nightkr added 6 commits August 30, 2023 14:39

Rename PodListenerInfo to SchedulingPodInfo

bf1ef39

Start Snafuizing listener integration

a05239e

More cleanup

db46cb7

Stop injecting node secret scope for node-scoped listener scopes

d31981b

Further cleanup

0982682

Drop stale dependencies

b600443

nightkr marked this pull request as ready for review September 1, 2023 14:59

nightkr requested review from siegfriedweber and a team September 1, 2023 15:00

siegfriedweber removed the request for review from a team September 6, 2023 06:47

siegfriedweber assigned nightkr Sep 6, 2023

nightkr added 5 commits September 7, 2023 17:39

Run pre-commit hooks

6d11c7f

Update op-rs

167279c

Fix stale reference to podlistenerses

d712fea

Add docs for listener scope

bf6445b

Add test, fail louder if no listener address was found

9ff7db7

Rename listener scope to listener-volume

3abbb69

nightkr force-pushed the feature/listener branch from dd7cb82 to 3abbb69 Compare September 13, 2023 13:36

siegfriedweber requested changes Oct 19, 2023

View reviewed changes

nightkr and others added 8 commits October 19, 2023 16:59

Update rust/operator-binary/src/backend/pod_info.rs

d71df8c

Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>

Drop now-unused listop CSI socket stuff

ebcda1a

Merge branch 'feature/listener' of github.com:stackabletech/secret-op…

2f3dc5f

…erator into feature/listener

Merge branch 'main' into feature/listener

9ad9cfc

Update docs/modules/secret-operator/pages/scope.adoc

2d7948d

Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>

Unbacktick Kube kind names

e7f11e0

Merge branch 'feature/listener' of github.com:stackabletech/secret-op…

a1a794f

…erator into feature/listener

Re-render README

664768b

nightkr requested review from siegfriedweber and a team October 30, 2023 13:39

siegfriedweber approved these changes Nov 6, 2023

View reviewed changes

nightkr added this pull request to the merge queue Nov 6, 2023

Merged via the queue into main with commit 915f243 Nov 6, 2023

nightkr deleted the feature/listener branch November 6, 2023 13:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Listener scope #310

Listener scope #310

nightkr commented Aug 29, 2023 •

edited by lfrancke

Loading

Author

Reviewer

Acceptance

nightkr commented Sep 1, 2023 •

edited

Loading

siegfriedweber commented Nov 6, 2023

siegfriedweber left a comment

Listener scope #310

Listener scope #310

Conversation

nightkr commented Aug 29, 2023 • edited by lfrancke Loading

Description

Definition of Done Checklist

Author

Reviewer

Acceptance

nightkr commented Sep 1, 2023 • edited Loading

siegfriedweber commented Nov 6, 2023

siegfriedweber left a comment

Choose a reason for hiding this comment

nightkr commented Aug 29, 2023 •

edited by lfrancke

Loading

nightkr commented Sep 1, 2023 •

edited

Loading