Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - krb5: Remove dummy key from keytab #285

Closed
wants to merge 3 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jun 19, 2023

Description

Fixes #283.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr requested a review from a team June 19, 2023 11:58
@sbernauer sbernauer self-requested a review June 19, 2023 12:18
@sbernauer
Copy link
Member

I'm running into thread 'main' panicked at 'no gssapi implementation found, install mit kerberos or heimdal', build.rs:47:9

$ apt search libgssapi
Sorting... Done
Full Text Search... Done
libgssapi-krb5-2/jammy-updates,now 1.19.2-2ubuntu0.2 amd64 [installed,automatic]
  MIT Kerberos runtime libraries - krb5 GSS-API Mechanism

libgssapi-perl/jammy 0.28-3build5 amd64
  Perl extension providing access to the GSSAPIv2 library

libgssapi3-heimdal/jammy 7.7.0+dfsg-3ubuntu1 amd64
  Heimdal Kerberos - GSSAPI support library

Is there something I am missing or maybe does the detection not work?

@sbernauer
Copy link
Member

Never mind, for whatever reason my git setup was messed up.
After really checking you branch out it builds 👍

@nightkr
Copy link
Member Author

nightkr commented Jun 19, 2023

I assume you're building with cargo build? I recently ran into the same thing (279a413), something seems to have got stricter recently...

I think on Ubuntu you'll need to install libkrb5-3 and maybe libkrb5-dev, but those should already be pulled in like that...

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@nightkr
Copy link
Member Author

nightkr commented Jun 19, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jun 19, 2023
@bors
Copy link
Contributor

bors bot commented Jun 19, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title krb5: Remove dummy key from keytab [Merged by Bors] - krb5: Remove dummy key from keytab Jun 19, 2023
@bors bors bot closed this Jun 19, 2023
@bors bors bot deleted the feature/dummy-begone-foul-demon branch June 19, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove dummy principal from KRB5 keytabs
2 participants