Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Split out MIT into separate SecretClass CRD section #257

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Split out MIT into separate SecretClass CRD section #257

wants to merge 7 commits into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Mar 29, 2023

Description

This should help prepare for making AD integration (#254) a non-breaking change.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@nightkr nightkr marked this pull request as ready for review March 29, 2023 12:18
@nightkr nightkr requested a review from a team March 29, 2023 12:18
sbernauer
sbernauer requested changes Mar 29, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's fine to not have a changelog entry as this change is only breaking dev, not a stable release

@nightkr nightkr requested a review from sbernauer March 30, 2023 08:30
sbernauer
sbernauer approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! I assume you did let the kuttl tests run

sbernauer
sbernauer reviewed Mar 30, 2023
View reviewed changes
@nightkr
Copy link
Member Author

nightkr commented Mar 30, 2023

bors r+

@nightkr
Copy link
Member Author

nightkr commented Mar 30, 2023

bors r-

@bors
Copy link
Contributor

bors bot commented Mar 30, 2023

Canceled.

@nightkr @sbernauer
Update CHANGELOG.md
d62790b 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@nightkr
Copy link
Member Author

nightkr commented Mar 30, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 30, 2023
@nightkr
Split out MIT into separate SecretClass CRD section (#257)
bdc4462 
# Description

This should help prepare for making AD integration (#254) a non-breaking change.



Co-authored-by: Natalie <teo@nullable.se>
@bors
Copy link
Contributor

bors bot commented Mar 30, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Split out MIT into separate SecretClass CRD section [Merged by Bors] - Split out MIT into separate SecretClass CRD section Mar 30, 2023
@bors bors bot closed this Mar 30, 2023
@bors bors bot deleted the feature/krb/prepare-ad branch March 30, 2023 08:55
@nightkr nightkr mentioned this pull request Mar 31, 2023
Closed
bors bot pushed a commit that referenced this pull request Mar 31, 2023
@nightkr
Update kerberos docs for the new multi-backend format (#261)
016cc5c 
# Description

This was changed in #257, but we forgot to update the docs then.
@nightkr nightkr mentioned this pull request Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nightkr @sbernauer