-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Secret-aware pod scheduling #125
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
added a commit
to stackabletech/operator-rs
that referenced
this pull request
May 6, 2022
Requires stackabletech/secret-operator#125, see that PR for motivation
This was referenced May 6, 2022
Closed
sbernauer
approved these changes
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall % comments
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
approved these changes
May 10, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 11, 2022
## Description Fixes #57 This requires pod volume definitions to switch from using the `csi` volume type (which are fully contained within the Kubelet's Pod lifecycle) to the `ephemeral` volume type (which is reified into a full `PersistentVolumeClaim` by the scheduler). For example: ```yaml --- apiVersion: v1 kind: Pod metadata: name: example-secret-consumer spec: volumes: - name: tls csi: driver: secrets.stackable.tech volumeAttributes: secrets.stackable.tech/class: tls secrets.stackable.tech/scope: node,pod,service=secret-consumer-nginx containers: - name: ubuntu image: ubuntu stdin: true tty: true volumeMounts: - name: tls mountPath: /tls ``` should be changed into: ```yaml --- apiVersion: v1 kind: Pod metadata: name: example-secret-consumer spec: volumes: - name: tls ephemeral: volumeClaimTemplate: metadata: annotations: secrets.stackable.tech/class: secret secrets.stackable.tech/scope: node,pod,service=secret-consumer-nginx spec: storageClassName: secrets.stackable.tech accessModes: - ReadWriteOnce resources: requests: storage: "1" containers: - name: ubuntu image: ubuntu stdin: true tty: true volumeMounts: - name: tls mountPath: /tls ``` `csi` volumes still work for now, but won't be able to take advantage of secret-aware scheduling. We will probably want to remove it after all operators and documentation have been migrated.
Pull request successfully merged into main. Build succeeded: |
bors bot
pushed a commit
to stackabletech/operator-templating
that referenced
this pull request
May 13, 2022
Merge this after stackabletech/secret-operator#125 get's merged and didn't case any problems I had a quick chat with @soenkeliebau and we agreed to give it a try
bors bot
pushed a commit
to stackabletech/operator-rs
that referenced
this pull request
May 13, 2022
## Description Requires stackabletech/secret-operator#125, see that PR for motivation Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #57
This requires pod volume definitions to switch from using the
csi
volume type (which are fully contained within the Kubelet's Pod lifecycle) to theephemeral
volume type (which is reified into a fullPersistentVolumeClaim
by the scheduler). For example:should be changed into:
csi
volumes still work for now, but won't be able to take advantage of secret-aware scheduling. We will probably want to remove it after all operators and documentation have been migrated.Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information