[Merged by Bors] - Remove secretLabels option from k8sSearch backend
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
approved these changes
May 5, 2022
|
Did you check that no examples for products or integration-tests use this attribute? |
It's completely redundant, since the name of the secretclass must be specified on the secrets anyway, preventing any kind of overlap.
I looked through the secret-op repo itself, but haven't searched downstream. |
|
https://github.com/search?q=org%3Astackabletech+secretLabels&type=code only finds matches within the secret-op repo itself. |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 5, 2022
## Description This never had any real purpose, since we always add the name of the `SecretClass` as a required label anyway.
|
Pull request successfully merged into main. Build succeeded: |
secretLabels option from k8sSearch backendsecretLabels option from k8sSearch backend
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This never had any real purpose, since we always add the name of the
SecretClassas a required label anyway.Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information