Add actions to build Helm charts to the operators and retire os package building. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
reviewed
Nov 18, 2021
template/deploy/helm/[[product]]-operator/templates/serviceaccount.yaml.j2
Show resolved
Hide resolved
siegfriedweber
previously requested changes
Nov 19, 2021
template/deploy/helm/[[product]]-operator/templates/serviceaccount.yaml.j2
Outdated
Show resolved
Hide resolved
template/deploy/helm/[[product]]-operator/templates/serviceaccount.yaml.j2
Outdated
Show resolved
Hide resolved
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
…ount.yaml.j2 Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Added chart linting config back in.
|
I've discussed this PR with @siegfriedweber and we agreed that the best way forward would be to include parts in the template, but also allowing to add parts directly in the operator repositories. I've addressed the comments as best I could. Sigi will have a look at the Hive operator and do some additional testing before we merge this. |
NickLarsenNZ
added a commit
that referenced
this pull request
Jan 30, 2025
Add the dynamic `checksum/config` annotation back in.
Previously, this annotation only appeared when `.Values.podAnnotations` was set.
It was only discovered broken by adding podAnnotations and seeing that the `include` context was invalid, leading to this error:
```
Error: template: trino-operator/templates/deployment.yaml:20:28: executing "trino-operator/templates/deployment.yaml" at <include (print $.Template.BasePath "/configmap.yaml") .>: error calling include: template: trino-operator/templates/configmap.yaml:4:10: executing "trino-operator/templates/configmap.yaml" at <.Files.Glob>: nil pointer evaluating interface {}.Glob
```
Note, this was always broken since inception in #7.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2025
Add the dynamic `checksum/config` annotation back in.
Previously, this annotation only appeared when `.Values.podAnnotations` was set.
It was only discovered broken by adding podAnnotations and seeing that the `include` context was invalid, leading to this error:
```
Error: template: trino-operator/templates/deployment.yaml:20:28: executing "trino-operator/templates/deployment.yaml" at <include (print $.Template.BasePath "/configmap.yaml") .>: error calling include: template: trino-operator/templates/configmap.yaml:4:10: executing "trino-operator/templates/configmap.yaml" at <.Files.Glob>: nil pointer evaluating interface {}.Glob
```
Note, this was always broken since inception in #7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4
fixes stackabletech/issues#135
Tested with: