Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(stackable-versioned): Add snapshot testing #881

Merged
merged 15 commits into from
Oct 2, 2024
Merged

test(stackable-versioned): Add snapshot testing #881

merged 15 commits into from
Oct 2, 2024

Conversation

Techassi
Copy link
Member

This PR adds snapshot tests to enable macro output testing.

Reviewer
Preview Give feedback

@Techassi Techassi self-assigned this Sep 27, 2024
NickLarsenNZ
NickLarsenNZ previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of suggestions and a question.

@Techassi @NickLarsenNZ
Update crates/stackable-versioned-macros/fixtures/README.md
18068e8 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@Techassi Techassi marked this pull request as ready for review September 30, 2024 14:07
@Techassi Techassi mentioned this pull request Sep 30, 2024
Open
NickLarsenNZ
NickLarsenNZ previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is still a good idea to keep the fail folder to make it obvious to the casual browser (without seeing the logic in trybuild.rs).

@Techassi
Copy link
Member Author

Techassi commented Oct 2, 2024 •
edited
Loading

I think it is still a good idea to keep the fail folder to make it obvious to the casual browser (without seeing the logic in trybuild.rs).

Done in 7bebb3a

@Techassi Techassi force-pushed the test/crd-versioning-snapshot branch from b44d8fa to 7bebb3a Compare October 2, 2024 08:23
@Techassi Techassi requested a review from NickLarsenNZ October 2, 2024 08:33
NickLarsenNZ
NickLarsenNZ approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 32a749d Oct 2, 2024
10 checks passed
@Techassi Techassi deleted the test/crd-versioning-snapshot branch October 2, 2024 09:56
@NickLarsenNZ NickLarsenNZ mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Techassi Techassi

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @NickLarsenNZ