Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support configuring JVM arguments #724

Merged
merged 3 commits into from
Jan 29, 2025
Merged

feat: Support configuring JVM arguments #724

merged 3 commits into from
Jan 29, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Dec 3, 2024 •
edited
Loading

Description

Part of stackabletech/issues#584

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@sbernauer sbernauer mentioned this pull request Dec 13, 2024
Open
@sbernauer sbernauer changed the title feat: Support experimental additional JVM arguments feat: Support configuring JVM arguments Dec 27, 2024
@sbernauer sbernauer marked this pull request as ready for review January 28, 2025 07:40
@sbernauer sbernauer requested a review from maltesander January 28, 2025 07:42
@sbernauer
Copy link
Member Author

Started https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/28/

maltesander
maltesander previously approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer requested a review from maltesander January 28, 2025 14:15
@sbernauer sbernauer enabled auto-merge January 29, 2025 10:43
maltesander
maltesander approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit 6dc7a56 Jan 29, 2025
17 checks passed
@sbernauer sbernauer deleted the feat/jvm-arguments branch January 29, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @maltesander