Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NiFi 2.0.0-M4 with 2.0.0 #702

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Replace NiFi 2.0.0-M4 with 2.0.0 #702

merged 3 commits into from
Nov 7, 2024

Conversation

maltesander
Copy link
Member

Description

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@maltesander maltesander requested a review from a team November 6, 2024 10:14
@maltesander maltesander self-assigned this Nov 6, 2024
@sbernauer
Copy link
Member

LGTM, but there are also some bumps I think we could do

diff --git a/docs/modules/nifi/examples/getting_started/getting_started.sh b/docs/modules/nifi/examples/getting_started/getting_started.sh
index a422a6e..42e22c4 100755
--- a/docs/modules/nifi/examples/getting_started/getting_started.sh
+++ b/docs/modules/nifi/examples/getting_started/getting_started.sh
@@ -157,7 +157,7 @@ metadata:
   name: simple-nifi
 spec:
   image:
-    productVersion: 1.27.0
+    productVersion: 2.0.0
   clusterConfig:
     authentication:
       - authenticationClass: simple-nifi-users
diff --git a/docs/modules/nifi/examples/getting_started/getting_started.sh.j2 b/docs/modules/nifi/examples/getting_started/getting_started.sh.j2
index f617525..e0b3cbb 100755
--- a/docs/modules/nifi/examples/getting_started/getting_started.sh.j2
+++ b/docs/modules/nifi/examples/getting_started/getting_started.sh.j2
@@ -157,7 +157,7 @@ metadata:
   name: simple-nifi
 spec:
   image:
-    productVersion: 1.27.0
+    productVersion: 2.0.0
   clusterConfig:
     authentication:
       - authenticationClass: simple-nifi-users
diff --git a/docs/modules/nifi/pages/usage_guide/custom_processors.adoc b/docs/modules/nifi/pages/usage_guide/custom_processors.adoc
index 9bb35c1..afecd1a 100644
--- a/docs/modules/nifi/pages/usage_guide/custom_processors.adoc
+++ b/docs/modules/nifi/pages/usage_guide/custom_processors.adoc
@@ -19,7 +19,7 @@ The basic Dockerfile below shows how to achieve this:
 
 [source,Dockerfile]
 ----
-FROM docker.stackable.tech/stackable/nifi:1.27.0-stackable0.0.0-dev
+FROM docker.stackable.tech/stackable/nifi:2.0.0-stackable0.0.0-dev
 COPY /path/to/your/nar.file /stackable/nifi/lib/
 ----
 
@@ -29,8 +29,8 @@ You then need to make this image available to your Kubernetes cluster and specif
 ----
 spec:
   image:
-    productVersion: 1.27.0
-    custom: "docker.company.org/nifi:1.27.0-customprocessor"
+    productVersion: 2.0.0
+    custom: "docker.company.org/nifi:2.0.0-customprocessor"
 ----
 
 Also read the xref:guides:custom-images.adoc[Using customized product images] guide for additional information.
@@ -100,7 +100,7 @@ metadata:
   name: simple-nifi
 spec:
   image:
-    productVersion: 1.27.0
+    productVersion: 2.0.0
   clusterConfig:
     authentication:
       - authenticationClass: simple-nifi-admin-user
diff --git a/docs/modules/nifi/pages/usage_guide/index.adoc b/docs/modules/nifi/pages/usage_guide/index.adoc
index 4e8e442..a048974 100644
--- a/docs/modules/nifi/pages/usage_guide/index.adoc
+++ b/docs/modules/nifi/pages/usage_guide/index.adoc
@@ -17,7 +17,7 @@ metadata:
   name: simple-nifi
 spec:
   image:
-    productVersion: 1.27.0
+    productVersion: 2.0.0
   clusterConfig:
     zookeeperConfigMapName: simple-nifi-znode  # <1>
     authentication:  # <2>
diff --git a/rust/crd/src/affinity.rs b/rust/crd/src/affinity.rs
index 4c07af1..6f58181 100644
--- a/rust/crd/src/affinity.rs
+++ b/rust/crd/src/affinity.rs
@@ -43,7 +43,7 @@ mod tests {
           name: simple-nifi
         spec:
           image:
-            productVersion: 1.27.0
+            productVersion: 2.0.0
           clusterConfig:
             authentication:
               - authenticationClass: nifi-admin-credentials-simple

@maltesander
Copy link
Member Author

Yeah, i get this and would say its ok (basically discussion vs LTS or latest in examples / getting started). But 2.0.0 is experimental, so i would not promote that in getting started etc. for now?

sbernauer
sbernauer previously approved these changes Nov 6, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion. On the other hand no one is probably testing 2.0.0 otherwise ^^
Just FYI you updated examples/simple-nifi-cluster.yaml

@maltesander
Copy link
Member Author

No strong opinion. On the other hand no one is probably testing 2.0.0 otherwise ^^ Just FYI you updated examples/simple-nifi-cluster.yaml

True, was from testing... changed back to 1.27.0 in e2aa48d

@maltesander maltesander added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit fb15452 Nov 7, 2024
17 checks passed
@maltesander maltesander deleted the nifi-2.0.0 branch November 7, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants