Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Support podOverrides #483

Closed
wants to merge 5 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 5, 2023

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer
Copy link
Member Author

@razvan razvan self-requested a review July 6, 2023 07:38
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good but I'm not sure about the tests

tests/templates/kuttl/resources/02-install-nifi.yaml.j2 Outdated Show resolved Hide resolved
tests/templates/kuttl/resources/02-assert.yaml.2 Outdated Show resolved Hide resolved
sbernauer and others added 2 commits July 6, 2023 10:11
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@sbernauer
Copy link
Member Author

resources test passed locally

@sbernauer sbernauer requested a review from razvan July 6, 2023 08:22
@sbernauer
Copy link
Member Author

bors r+
Thx!

bors bot pushed a commit that referenced this pull request Jul 6, 2023
# Description

*Please add a description here. This will become the commit message of the merge request later.*
@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Support podOverrides [Merged by Bors] - feat: Support podOverrides Jul 6, 2023
@bors bors bot closed this Jul 6, 2023
@bors bors bot deleted the feat/pod-overrides branch July 6, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants