Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Openshift compatibility #446

Closed
wants to merge 16 commits into from
Closed

[Merged by Bors] - Openshift compatibility #446

wants to merge 16 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Mar 31, 2023 •
edited
Loading

Description

Add RBAC components for the operator to run on Openshift.

Subset of tests on openshift:

image

Subset of tests on openshift II:

--- PASS: kuttl (2095.61s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/logging_zookeeper-latest-3.8.0-stackable23.4.0-rc2_nifi-1.18.0-stackable23.4.0-rc2 (134.70s)
        --- PASS: kuttl/harness/cluster_operation_zookeeper-latest-3.8.0-stackable23.4.0-rc2_nifi-latest-1.18.0-stackable23.4.0-rc2 (254.16s)
        --- PASS: kuttl/harness/orphaned_resources_zookeeper-latest-3.8.0-stackable23.4.0-rc2_nifi-1.18.0-stackable23.4.0-rc2 (356.38s)
        --- PASS: kuttl/harness/upgrade_zookeeper-latest-3.8.0-stackable23.4.0-rc2_nifi_old-1.16.3-stackable23.4.0-rc2_nifi_new-1.18.0-stackable23.4.0-rc2 (379.31s)
        --- PASS: kuttl/harness/resources_zookeeper-latest-3.8.0-stackable23.4.0-rc2_nifi-1.18.0-stackable23.4.0-rc2 (41.03s)
        --- PASS: kuttl/harness/ldap_zookeeper-latest-3.8.0-stackable23.4.0-rc2_nifi-1.18.0-stackable23.4.0-rc2_ldap-use-tls-false_openshift-true (219.23s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.8.0-stackable23.4.0-rc2_nifi-1.18.0-stackable23.4.0-rc2_listener-class-external-unstable (253.14s)
        --- PASS: kuttl/harness/smoke_zookeeper-3.8.0-stackable23.4.0-rc2_nifi-1.18.0-stackable23.4.0-rc2_listener-class-cluster-internal (239.95s)
        --- PASS: kuttl/harness/ldap_zookeeper-latest-3.8.0-stackable23.4.0-rc2_nifi-1.18.0-stackable23.4.0-rc2_ldap-use-tls-true_openshift-true (207.32s)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 mentioned this pull request Mar 31, 2023
Closed
2 tasks
@adwk67 adwk67 self-assigned this Mar 31, 2023
@adwk67 adwk67 marked this pull request as ready for review April 4, 2023 19:20
@adwk67 adwk67 requested a review from a team April 5, 2023 10:02
@maltesander maltesander requested review from maltesander and removed request for a team April 12, 2023 14:00
maltesander
maltesander requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things.

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
maltesander
maltesander approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67
Copy link
Member Author

adwk67 commented Apr 12, 2023

bors merge

bors bot pushed a commit that referenced this pull request Apr 12, 2023
@adwk67
Openshift compatibility (#446)
0f901d1 
# Description

Add RBAC components for the operator to run on Openshift.

Subset of tests on openshift:

![image](https://user-images.githubusercontent.com/1712947/229998957-346b8cb3-3c22-4bd2-9516-58ede387dcc1.png)
@bors
Copy link
Contributor

bors bot commented Apr 12, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Openshift compatibility [Merged by Bors] - Openshift compatibility Apr 12, 2023
@bors bors bot closed this Apr 12, 2023
@bors bors bot deleted the openshift-compatibility branch April 12, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@adwk67 adwk67

Labels
release/23.4.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adwk67 @maltesander @lfrancke @sbernauer