Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Removed tools image #397

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Removed tools image #397

wants to merge 4 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Dec 13, 2022 •
edited
Loading

Description

Removed tools image. Working locally with locally build docker image.

Blocked by: stackabletech/docker-images#266

TODO:

  • Adapt stackable versions after new tags are build

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander added status/blocked release/23.1.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Dec 13, 2022
@maltesander maltesander self-assigned this Dec 13, 2022
@maltesander maltesander mentioned this pull request Dec 13, 2022
Merged
@sbernauer sbernauer self-requested a review December 13, 2022 13:23
sbernauer
sbernauer approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when test pass

@maltesander
Copy link
Member Author

test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/18/

@maltesander maltesander mentioned this pull request Dec 13, 2022
Closed
6 tasks
@maltesander maltesander marked this pull request as ready for review December 13, 2022 16:53
@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Dec 14, 2022
@maltesander
Removed tools image (#397)
a5c9c17 
# Description

Removed tools image. Working locally with locally build docker image.

Blocked by:  stackabletech/docker-images#266

TODO:

- [x] Adapt stackable versions after new tags are build



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Removed tools image [Merged by Bors] - Removed tools image Dec 14, 2022
@bors bors bot closed this Dec 14, 2022
@bors bors bot deleted the remove-tools-image branch December 14, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@maltesander maltesander

Labels
release/23.1.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @sbernauer