Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Orphaned resources handling #319

Closed
wants to merge 8 commits into from

Conversation

soenkeliebau
Copy link
Member

Description

Ensure the operator correctly deletes orphaned resources.

Closes #244

sister PR that was modelled close to stackabletech/hbase-operator#215

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Statefulsets, Services, ConfigMaps that are not needed anymore due to the configuration of the NifiCluster crd have so far not been removed.
After this PR resources that belong to rolegroups that are no longer around will be deleted properly.
Added test case for resource deletion.

Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
# Conflicts:
#	Cargo.lock
#	rust/crd/Cargo.toml
#	rust/crd/src/authentication.rs
#	rust/operator-binary/Cargo.toml
#	rust/operator-binary/src/controller.rs
Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
@stackable-bot
Copy link
Contributor

stackable-bot commented Aug 4, 2022

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
Regenerated charts due to CRD changes

Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
@soenkeliebau soenkeliebau requested a review from a team August 5, 2022 13:11
@nightkr nightkr self-requested a review August 5, 2022 14:06
deny.toml Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
…ting.

Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
@soenkeliebau
Copy link
Member Author

i've pushed an update @teozkr
integration tests are still running on my end ..

Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soenkeliebau
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 11, 2022
# Description

Ensure the operator correctly deletes orphaned resources.

Closes #244 

sister PR that was modelled close to stackabletech/hbase-operator#215
@bors
Copy link
Contributor

bors bot commented Aug 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Orphaned resources handling [Merged by Bors] - Orphaned resources handling Aug 11, 2022
@bors bors bot closed this Aug 11, 2022
@bors bors bot deleted the feat/orphaned_resources branch August 11, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle stale information/clean up stale resources
3 participants