Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Adapt crds to crd review #277

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - Adapt crds to crd review #277

wants to merge 11 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jun 6, 2022 •
edited by soenkeliebau
Loading

Description

  • Adapted to CRD review (see changelog)
  • Fixed tests

closes #233, #234, #235

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team June 6, 2022 14:21
@maltesander maltesander self-assigned this Jun 6, 2022
This was linked to issues Jun 6, 2022
method “SingleUser” -> camelCase #234
Closed
authenticationConfig & sensitivePropertiesConfig -> top level config object #235
Closed
@backstreetkiwi
Copy link
Contributor

test run successfully: https://ci.stackable.tech/view/02%20Component%20Tests%20(flex)/job/NiFi%20Operator%20Integration%20Tests%20(flex)/26/

soenkeliebau added a commit that referenced this pull request Jun 7, 2022
@soenkeliebau
Fix tests (taken from #277 - should merge fine with that PR if this g…
2acf372 
…ets into main first) and enabled CI for testing (same deal, also from #277).
sbernauer
sbernauer reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that into Nifi, just put in the same comments as in the other PRs - so no complete Review

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/controller.rs Outdated Show resolved Hide resolved
@maltesander maltesander requested a review from a team June 10, 2022 11:33
backstreetkiwi
backstreetkiwi approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@backstreetkiwi backstreetkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI successful: https://ci.stackable.tech/view/02%20Component%20Tests%20(flex)/job/NiFi%20Operator%20Integration%20Tests%20(flex)/32/

soenkeliebau
soenkeliebau approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, but overall lgtm

rust/crd/src/lib.rs
.context(ObjectHasNoVersionSnafu)
}

/// Returns our semver representation for product config e.g. 1.15.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer keeping code like this in the framework.

We should probably agree on a default handling for this field and how it is expanded into the proper tag to pull.
That being said, until we have that this is fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah agreed, execept for trino i think all our products use semver anyways.

@soenkeliebau
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Jun 14, 2022
@maltesander @backstreetkiwi
Adapt crds to crd review (#277)
db33e5e 
# Description

- Adapted to CRD review (see changelog)
- Fixed tests

closes #233, #234, #235



Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Nikolaus Winter <mail@nikolaus-winter.de>
@bors
Copy link
Contributor

bors bot commented Jun 14, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Adapt crds to crd review [Merged by Bors] - Adapt crds to crd review Jun 14, 2022
@bors bors bot closed this Jun 14, 2022
@bors bors bot deleted the adapt_crds_to_crd_review branch June 14, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer left review comments

@soenkeliebau soenkeliebau soenkeliebau approved these changes

@backstreetkiwi backstreetkiwi backstreetkiwi approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@maltesander @backstreetkiwi @soenkeliebau @sbernauer