Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing RBAC permissions for finalizers #246

Merged
merged 12 commits into from
Nov 8, 2024
Merged

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Nov 7, 2024

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@adwk67
Copy link
Member Author

adwk67 commented Nov 7, 2024

Test still fails for Hostname.
kubectl get listener/listener-nginx-long-name-approaching-k8s-limits-0 -o jsonpath='http://{.status.ingressAddresses[0].address}:{.status.ingressAddresses[0].ports.http}/pod-name'
trys e.g.
curl -s http://worker-wfcawizc:32396/pod-name
but fails with e.g.

curl http://worker-i7sss39m:30283/pod-name
curl: (6) Could not resolve host: worker-i7sss39m

On kind we have e.g.:

curl -s http://stackable-data-platform-control-plane:31008/pod-name
nginx-long-name-approaching-k8s-limits-0

@adwk67
Copy link
Member Author

adwk67 commented Nov 7, 2024

Test case for Hostname will be omitted on OKD as it not clear if this is a limitation in OKD.
Kind: (the test runs but the curl commands are deactivated)

--- PASS: kuttl (20.60s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false_addressType-Hostname (10.30s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false_addressType-IP (10.31s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-false_addressType-HostnameConservative (10.25s)

OKD:

--- PASS: kuttl (120.01s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-true_addressType-Hostname (40.39s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-true_addressType-HostnameConservative (101.85s)
        --- PASS: kuttl/harness/smoke-nodeport_openshift-true_addressType-IP (111.76s)

@adwk67 adwk67 marked this pull request as ready for review November 7, 2024 11:16
@adwk67 adwk67 self-assigned this Nov 7, 2024
@adwk67 adwk67 requested a review from sbernauer November 7, 2024 14:06
sbernauer
sbernauer previously approved these changes Nov 7, 2024
@sbernauer sbernauer changed the title fix: Add RBAC permissions for finalizers fix: Add missing RBAC permissions for finalizers Nov 7, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adwk67 adwk67 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit b2559c3 Nov 8, 2024
17 checks passed
@adwk67 adwk67 deleted the fix/openshift-rbac-pv branch November 8, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants