Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ClusterResources for Listener controller #232

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 7, 2024

Description

Fixes #221

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@nightkr nightkr requested a review from a team October 7, 2024 14:51
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this using the hdfs-op getting started guide I get the following error
2024-10-11T06:46:22.037036Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="listener.listeners.stackable.tech" error=reconciler for object Listener.v1alpha1.listeners.stackable.tech/listener-simple-hdfs-namenode-default-0.default failed error.sources=[failed to apply Service.v1./listener-simple-hdfs-namenode-default-0.default, label "app.kubernetes.io/instance" contains unexpected values - expected "listener-simple-hdfs-namenode-default-0", got "simple-hdfs"]

Can we please run the hdfs-operator kuttl suite with this listener-op version before merging?

@nightkr
Copy link
Member Author

nightkr commented Oct 11, 2024

Oh, ouch. Looking into that.

@nightkr
Copy link
Member Author

nightkr commented Oct 11, 2024

Looks like that's due to stackabletech/operator-rs#887.

@nightkr
Copy link
Member Author

nightkr commented Oct 18, 2024

@sbernauer Should be fixed by f462caf.

@nightkr nightkr requested a review from sbernauer October 18, 2024 11:31
@nightkr
Copy link
Member Author

nightkr commented Oct 18, 2024

HDFS tests passed, aside from some flakiness in smoke_hadoop-3.4.0_zookeeper-3.9.2_zookeeper-latest-3.9.2_number-of-datanodes-2_datanode-pvcs-2hdd-1ssd_listener-class-cluster-internal_openshift-false.

@nightkr nightkr added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit ac51ec7 Oct 21, 2024
31 checks passed
@nightkr nightkr deleted the feature/cluster-resources branch October 21, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ClusterResources to manage objects created by Listener controller
2 participants