Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Consolidate workspace members #425

Merged
merged 2 commits into from
Nov 15, 2023
Merged

refactor: Consolidate workspace members #425

merged 2 commits into from
Nov 15, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Nov 15, 2023 •
edited
Loading

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@NickLarsenNZ NickLarsenNZ self-requested a review November 15, 2023 16:16
NickLarsenNZ
NickLarsenNZ previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Nov 15, 2023
@sbernauer sbernauer removed this pull request from the merge queue due to a manual request Nov 15, 2023
@sbernauer sbernauer enabled auto-merge November 15, 2023 16:33
NickLarsenNZ
NickLarsenNZ approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbernauer sbernauer added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 934beea Nov 15, 2023
@sbernauer sbernauer deleted the refactor/consolidate-workspace-members branch November 15, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @NickLarsenNZ