Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Superset v1.4.2, v1.5.3, v2.0.1, v2.1.0 #216

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 13, 2022

For stackabletech/superset-operator#237

Tested using the trino-taxi-data demo
Screenshot_20221013_093349

@lfrancke
Copy link
Member

This is 2.0.0, can we please support 2.0.1 instead?

Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. [NEW VERSION] Superset 2.0.1, 2.1.0 superset-operator#237 currently wants Superset version 2.0.1 and not 2.0.0. The constraints file must be re-created then because it changed slightly.
  2. https://github.com/apache/superset/blob/2.0.0/requirements/docker.txt should be appended to superset/constraints-2.0.0.txt because these dependencies are used in the superset/Dockerfile.

superset/CHANGELOG.md Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

@lfrancke 2.0.1 has not been released yet. Bumping from 2.0.0 to 2.0.1 should be easy though

@lfrancke
Copy link
Member

Then it is in the process of being voted on. I checked last week. I Believe. Can we wait for that?

@lfrancke
Copy link
Member

@sbernauer
Copy link
Member Author

Yeah sure! Move to on hold then?

@lfrancke
Copy link
Member

Ah, the vote did not pass. Still, let's wait a few days. End of next week we can decide again

@lfrancke lfrancke linked an issue Oct 18, 2022 that may be closed by this pull request
2 tasks
@maltesander maltesander changed the title Add support for Superset 2.0.0 Add support for Superset v1.4.2, v1.5.3, v2.0.1, v2.1.0 Apr 25, 2023
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maltesander
Copy link
Member

maltesander commented Apr 25, 2023

--- PASS: kuttl (877.14s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/logging_superset-1.3.2-stackable0.0.0-dev_openshift-false (51.60s)
--- PASS: kuttl/harness/ldap_superset-2.0.1-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (69.67s)
--- PASS: kuttl/harness/ldap_superset-1.3.2-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (69.78s)
--- PASS: kuttl/harness/ldap_superset-2.0.1-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (63.92s)
--- PASS: kuttl/harness/ldap_superset-1.5.3-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (69.24s)
--- PASS: kuttl/harness/ldap_superset-1.5.3-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (71.94s)
--- PASS: kuttl/harness/logging_superset-2.1.0-stackable0.0.0-dev_openshift-false (54.52s)
--- PASS: kuttl/harness/ldap_superset-1.3.2-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (66.45s)
--- PASS: kuttl/harness/ldap_superset-1.5.3-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (69.44s)
--- PASS: kuttl/harness/ldap_superset-1.4.2-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (72.90s)
--- PASS: kuttl/harness/ldap_superset-1.3.2-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (65.76s)
--- PASS: kuttl/harness/ldap_superset-1.4.2-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (67.45s)
--- PASS: kuttl/harness/logging_superset-1.5.3-stackable0.0.0-dev_openshift-false (53.37s)
--- PASS: kuttl/harness/cluster-operation_superset-latest-2.1.0-stackable0.0.0-dev_openshift-false (90.09s)
--- PASS: kuttl/harness/ldap_superset-1.4.2-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (68.98s)
--- PASS: kuttl/harness/logging_superset-2.0.1-stackable0.0.0-dev_openshift-false (53.03s)
--- PASS: kuttl/harness/druid-connection_superset-1.4.2-stackable0.0.0-dev_openshift-false (57.35s)
--- PASS: kuttl/harness/druid-connection_superset-1.3.2-stackable0.0.0-dev_openshift-false (56.90s)
--- PASS: kuttl/harness/logging_superset-1.4.2-stackable0.0.0-dev_openshift-false (49.83s)
--- PASS: kuttl/harness/druid-connection_superset-2.1.0-stackable0.0.0-dev_openshift-false (55.12s)
--- PASS: kuttl/harness/smoke_superset-2.0.1-stackable0.0.0-dev_openshift-false (210.47s)
--- PASS: kuttl/harness/druid-connection_superset-2.0.1-stackable0.0.0-dev_openshift-false (53.13s)
--- PASS: kuttl/harness/druid-connection_superset-1.5.3-stackable0.0.0-dev_openshift-false (55.93s)
--- PASS: kuttl/harness/resources_superset-latest-2.1.0-stackable0.0.0-dev_openshift-false (42.64s)
--- PASS: kuttl/harness/smoke_superset-2.1.0-stackable0.0.0-dev_openshift-false (209.34s)
--- PASS: kuttl/harness/ldap_superset-2.1.0-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (69.40s)
--- PASS: kuttl/harness/smoke_superset-1.5.3-stackable0.0.0-dev_openshift-false (54.75s)
--- PASS: kuttl/harness/ldap_superset-2.1.0-stackable0.0.0-dev_ldap-authentication-insecure-tls_openshift-false (63.04s)
--- PASS: kuttl/harness/smoke_superset-1.4.2-stackable0.0.0-dev_openshift-false (208.84s)
--- PASS: kuttl/harness/ldap_superset-2.1.0-stackable0.0.0-dev_ldap-authentication-no-tls_openshift-false (68.43s)
--- PASS: kuttl/harness/smoke_superset-1.3.2-stackable0.0.0-dev_openshift-false (208.20s)
--- PASS: kuttl/harness/ldap_superset-2.0.1-stackable0.0.0-dev_ldap-authentication-server-verification-tls_openshift-false (67.10s)
PASS

@maltesander maltesander merged commit acaebcb into main Apr 25, 2023
@maltesander maltesander deleted the superset-2.0.0 branch April 25, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW VERSION] Superset 2.0.1, 2.1.0
5 participants