-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Superset v1.4.2, v1.5.3, v2.0.1, v2.1.0 #216
Conversation
This is 2.0.0, can we please support 2.0.1 instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [NEW VERSION] Superset 2.0.1, 2.1.0 superset-operator#237 currently wants Superset version 2.0.1 and not 2.0.0. The constraints file must be re-created then because it changed slightly.
- https://github.com/apache/superset/blob/2.0.0/requirements/docker.txt should be appended to
superset/constraints-2.0.0.txt
because these dependencies are used in thesuperset/Dockerfile
.
@lfrancke 2.0.1 has not been released yet. Bumping from 2.0.0 to 2.0.1 should be easy though |
Then it is in the process of being voted on. I checked last week. I Believe. Can we wait for that? |
Yeah sure! Move to on hold then? |
Ah, the vote did not pass. Still, let's wait a few days. End of next week we can decide again |
d68722e
to
671cd05
Compare
671cd05
to
490739e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
--- PASS: kuttl (877.14s) |
For stackabletech/superset-operator#237
Tested using the trino-taxi-data demo