-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Evict pods based on expiry annotations #20
Conversation
This is the flip side of stackabletech/secret-operator#114, and implements the actual deletion of the pods once they expire.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % doc suggestions
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
bors r+ |
## Description This is the flip side of stackabletech/secret-operator#114, and implements the actual eviction of the pods once they expire. - [X] Time-based eviction (`restarter.stackable.tech/expires-at.{TAG}` annotation) - [ ] Dependency-based eviction (like the current STS eviction)
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors r+ |
## Description This is the flip side of stackabletech/secret-operator#114, and implements the actual eviction of the pods once they expire. - [X] Time-based eviction (`restarter.stackable.tech/expires-at.{TAG}` annotation) - [ ] Dependency-based eviction (like the current STS eviction)
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors r+ |
## Description This is the flip side of stackabletech/secret-operator#114, and implements the actual eviction of the pods once they expire. - [X] Time-based eviction (`restarter.stackable.tech/expires-at.{TAG}` annotation) - [ ] Dependency-based eviction (like the current STS eviction)
Pull request successfully merged into main. Build succeeded: |
Description
This is the flip side of stackabletech/secret-operator#114, and implements the actual eviction of the pods once they expire.
restarter.stackable.tech/expires-at.{TAG}
annotation)Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information