Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v3.1.0 #785

Closed
wants to merge 3 commits into from
Closed

Release/v3.1.0 #785

wants to merge 3 commits into from

Conversation

vincentsarago
Copy link
Member

No description provided.

@@ -7,7 +7,7 @@

install_requires = [
"brotli_asgi",
"stac-fastapi.types~=3.0",
"stac-fastapi.types~=3.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gadomski I'd love to have your objective opinion on this

Because 3.1 introduces breaking changes (filter -> filter_expr and datetime type) should we:

  • make a 4.0 instead
  • set api and extensions dependencies to >=3.1,<4.0
  • set api and extensions dependencies to ==3.1.*

ref: #678

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 tricky one. This repo is like halfway between a library and an application (in my head) which makes versioning weird. I'm a bit more inclined to just go for a 4.0 even though there isn't too much in it ... versions are cheap and at least we'll surprise other folks less when their code breaks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants