add from_extensions class method to create CollectionSearch extensions classes #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Aug 21, 2024
stac_fastapi/extensions/stac_fastapi/extensions/core/collection_search/collection_search.py
Outdated
Show resolved
Hide resolved
vincentsarago
commented
Aug 21, 2024
stac_fastapi/extensions/stac_fastapi/extensions/core/collection_search/collection_search.py
Outdated
Show resolved
Hide resolved
vincentsarago
commented
Aug 21, 2024
stac_fastapi/extensions/stac_fastapi/extensions/core/collection_search/collection_search.py
Outdated
Show resolved
Hide resolved
vincentsarago
commented
Aug 21, 2024
stac_fastapi/extensions/stac_fastapi/extensions/core/collection_search/collection_search.py
Outdated
Show resolved
Hide resolved
vincentsarago
commented
Aug 21, 2024
stac_fastapi/extensions/stac_fastapi/extensions/core/collection_search/collection_search.py
Outdated
Show resolved
Hide resolved
vincentsarago
commented
Aug 21, 2024
stac_fastapi/extensions/stac_fastapi/extensions/core/collection_search/collection_search.py
Outdated
Show resolved
Hide resolved
b57cb7c to
a959cd8
Compare
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'STAC FastAPI Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: a959cd8 | Previous: 4979a89 | Ratio |
|---|---|---|---|
Items With Model validation (200) |
40.17875478124901 iter/sec (stddev: 0.01999789596876311) |
55.33057294465105 iter/sec (stddev: 0.011217805523287447) |
1.38 |
This comment was automatically generated by workflow using github-action-benchmark.
jonhealy1
approved these changes
Aug 23, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: stac-utils/stac-fastapi-pgstac#136
This PR adds
from_extensionsclass method to help users creating CollectionSearch extensions classes when providing a list of available extensions. This will essentially create GET/POST models and also add the Conformances classes.Caveat: This is based on extensions classes names (but couldn't find anything smarter 🙉). We can't use the classes themself because it would create circular dependencies!
This is meant to be used in some
genericcases where users don't provide custom extensions (at least from the conformance POV)