Improve logging of pgSTAC tests #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Thanks for the contribution!
We'll need to backport this to https://github.com/stac-utils/stac-fastapi-pgstac/ once #555 is merged, but that's about the same level of difficulty as moving this PR, and as #555 isn't merged yet, I figure it doesn't hurt to merge here.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
An attempt to clean up the logging within the codebase to avoid unnecessary print statements generated during tests unless a higher
LOG_LEVELenvironment variable is set.PR Checklist:
pre-commithooks pass locallymake test)make docs)